Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scene logs #442

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add scene logs #442

wants to merge 12 commits into from

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Feb 12, 2025 •
edited
Loading

requires decentraland/js-sdk-toolchain#1070

closes #327 (figma link included in issue)

Scene Debugger Implementation

This PR introduces a new Scene Debugger feature that allows developers to view console output from their scenes in a dedicated window.

Key Changes

New Features

  • Added Scene Debugger window implementation with real-time console output display
  • Implemented ANSI color support for console output using ansi-to-html
  • Added circular buffer implementation for efficient log management
  • Created new debugger UI with auto-scrolling logs view

Dependencies

  • Added ansi-to-html package for console color support

Testing

  • Test debugger window creation
  • Verify log output and ANSI color rendering
  • Test multiple debugger windows
  • Verify cleanup when closing windows
  • Test auto-scrolling behavior
Screenshot 2025-02-17 at 1 21 11 PM

NOTE: debugger is not yet working on prod builds (conf issue, working on it)

@nicoecheza nicoecheza force-pushed the add/scene-logs branch 4 times, most recently from 8a54cd0 to b2f3e6b Compare February 13, 2025 16:53
@nicoecheza nicoecheza changed the title Add/scene logs Add scene logs Feb 17, 2025
@nicoecheza nicoecheza force-pushed the add/scene-logs branch 5 times, most recently from bf3ed69 to 6034d17 Compare February 17, 2025 22:55
@github-actions GitHub Actions
Copy link

Test this pull request on windows-latest

Download the correct version for your architecture:

win-x64

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

Test this pull request on macos-latest

Download the correct version for your architecture:

mac-arm64
mac-x64

Click here if you don't know which version to download

For running this unsigned version of the app, you will need to run the xattr command on it:

  1. Extract the app from the downloaded .dmg file (double-click it)
  2. Place the extracted app anywhere you like in your file system
  3. Open a terminal on the directory where the app is
  4. Run xattr -c app-name, replacing "app-name" for the actual name of the app
  5. Double-click the app ✅

@nicoecheza nicoecheza force-pushed the add/scene-logs branch 2 times, most recently from 179abd7 to 505eb1d Compare February 17, 2025 23:18
@nicoecheza nicoecheza marked this pull request as ready for review February 21, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
SDK
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Console to show error messages
1 participant
@nicoecheza